Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix CUDA CI builds #3549

Merged
merged 1 commit into from
Nov 10, 2020
Merged

[ci] fix CUDA CI builds #3549

merged 1 commit into from
Nov 10, 2020

Conversation

StrikerRUS
Copy link
Collaborator

I was wrong in #3524 (review). I guess to use v2 we need update Actions runner first: actions/checkout#348. @guolinke Could you help please? For now rollback to v1.

Run actions/[email protected]
  with:
    fetch-depth: 5
    submodules: true
    repository: microsoft/LightGBM
    token: ***
    ssh-strict: true
    persist-credentials: true
    clean: true
    lfs: false
Error: No such file or directory

@StrikerRUS StrikerRUS added the fix label Nov 9, 2020
@StrikerRUS StrikerRUS requested a review from guolinke November 9, 2020 22:18
jameslamb
jameslamb approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, ok!

@StrikerRUS is this branch up to date with master? I see the MINGW failure on GitHub Actions and it's making me nervous...https://github.com/microsoft/LightGBM/pull/3549/checks?check_run_id=1376800973

@StrikerRUS
Copy link
Collaborator Author

@jameslamb

is this branch up to date with master? I see the MINGW failure on GitHub Actions and it's making me nervous

Ah! Yes, it should be!

image

Please note that the error is different from the previous one we faced with MinGW.

Trying to build with MinGW
-- The C compiler identification is GNU 4.9.3
-- The CXX compiler identification is GNU 4.9.3
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Rtools/mingw_64/bin/gcc.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Rtools/mingw_64/bin/g++.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- R version passed into FindLibR.cmake: 3.6.3
-- Found LibR: D:/a/LightGBM/LightGBM/RLibrary/R  
-- LIBR_EXECUTABLE: D:/a/LightGBM/LightGBM/RLibrary/R/bin/x64/R.exe
-- LIBR_INCLUDE_DIRS: D:/a/LightGBM/LightGBM/RLibrary/R/include
-- LIBR_CORE_LIBRARY: D:/a/LightGBM/LightGBM/RLibrary/R/bin/x64/R.dll
-- Found OpenMP_C: -fopenmp  
-- Found OpenMP_CXX: -fopenmp  
-- Found OpenMP: TRUE   
-- Performing Test MM_PREFETCH
-- Performing Test MM_PREFETCH - Failed
-- Performing Test MM_MALLOC
-- Performing Test MM_MALLOC - Failed
-- Configuring done
-- Generating done
-- Build files have been written to: D:/a/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/build
-- R version passed into FindLibR.cmake: 3.6.3
-- LIBR_EXECUTABLE: D:/a/LightGBM/LightGBM/RLibrary/R/bin/x64/R.exe
-- LIBR_INCLUDE_DIRS: D:/a/LightGBM/LightGBM/RLibrary/R/include
-- LIBR_CORE_LIBRARY: D:/a/LightGBM/LightGBM/RLibrary/R/bin/x64/R.dll
-- Configuring done
-- Generating done
-- Build files have been written to: D:/a/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/build
Building lib_lightgbm
Scanning dependencies of target _lightgbm
[  2%] Building CXX object CMakeFiles/_lightgbm.dir/src/application/application.cpp.obj
D:\a\LightGBM\LightGBM\lightgbm.Rcheck\00_pkg_src\lightgbm\src\src\application\application.cpp:1:0: warning: -fPIC ignored for target (all code is position independent)
 /*!
 ^
In file included from D:/a/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/include/LightGBM/config.h:15:0,
                 from D:/a/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/include/LightGBM/application.h:8,
                 from D:\a\LightGBM\LightGBM\lightgbm.Rcheck\00_pkg_src\lightgbm\src\src\application\application.cpp:5:
D:/a/LightGBM/LightGBM/lightgbm.Rcheck/00_pkg_src/lightgbm/src/include/LightGBM/meta.h:8:19: fatal error: cstdint: No such file or directory
 #include <cstdint>
                   ^
compilation terminated.
CMakeFiles\_lightgbm.dir\build.make:81: recipe for target 'CMakeFiles/_lightgbm.dir/src/application/application.cpp.obj' failed
mingw32-make.exe[3]: *** [CMakeFiles/_lightgbm.dir/src/application/application.cpp.obj] Error 1
CMakeFiles\Makefile2:122: recipe for target 'CMakeFiles/_lightgbm.dir/all' failed
mingw32-make.exe[2]: *** [CMakeFiles/_lightgbm.dir/all] Error 2
CMakeFiles\Makefile2:129: recipe for target 'CMakeFiles/_lightgbm.dir/rule' failed
mingw32-make.exe[1]: *** [CMakeFiles/_lightgbm.dir/rule] Error 2
makefile:195: recipe for target '_lightgbm' failed
mingw32-make.exe: *** [_lightgbm] Error 2

As we now skip linker checks during PROJECT the error is happening later during real project compilation.

@guolinke
Copy link
Collaborator

from the directory, it seems the bin is already updated to the latest version:
image

should we update it manually?

@guolinke
Copy link
Collaborator

And I think we install the runner later than that issue.

@StrikerRUS
Copy link
Collaborator Author

@guolinke OK, thanks for the details! Then we probably hit this error with node installation/linking: actions/checkout#334, actions/checkout#333. But I think we don't use any features from v2, so it's quite safe to keep using v1.

@StrikerRUS StrikerRUS merged commit e9f5169 into master Nov 10, 2020
@StrikerRUS StrikerRUS deleted the cuda_ci_fix branch November 10, 2020 20:38
@StrikerRUS StrikerRUS mentioned this pull request Nov 3, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StrikerRUS @guolinke @jameslamb